-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPDATED FEATURE-993] Migrate Image Training Endpoint to Django #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
reviewed
Nov 19, 2023
karkir0003
requested changes
Nov 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work on this so far. had a few nits + questions. please address and then re-request review
…ayground into feature-993-updated
codingwithsurya
force-pushed
the
feature-993-updated
branch
from
November 20, 2023 01:37
a6448a8
to
69d1477
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
karkir0003
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue Number Here: Feature #993
What user problem are we solving?
With the ongoing migration from Flask Blueprint to Django for better scalability and maintainability, we need to ensure that the training endpoints for image datasets continue to function as expected. Users need a reliable endpoint to submit image training requests and this migration aims to improve the overall infrastructure.
What solution does this PR provide?
This PR introduces the /image route within the Django framework, replacing the old Flask Blueprint route. The new route handles image training requests, particularly focusing on classification tasks as regression is not supported. The structure of this endpoint is mirrored from the specified reference, with adjustments made to fit the Django framework. The old image train code served as inspiration for ensuring that the necessary features and behaviors are retained.
Testing Methodology
Testing yet to be done but to verify the functionality and integrity of the new /image route, but when testing begins, we can submit training requests using torch built-in datasets (MNIST, FashionMNIST) to ensure that models train as expected and the endpoint returns accurate results.
Also use postman for testing .
Any other considerations
THIS IS UPDATED PR.